Wireshark-commits: [Wireshark-commits] master-2.6 536fb94: Fix handling of invalid type values.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 09 Sep 2018 17:47:14 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=536fb9403a5f6bcc060aaa2a1f35d8d0225bb1fd
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

536fb94 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix handling of invalid type values.
    
    If vType_get_type() returns NULL, that means that the packet is bad, not
    that the dissector is bad.  Report it as such.
    
    Bug: 15119
    Change-Id: I8e66fcece2b526ef9edbf948862f8fc5bea25d74
    Reviewed-on: https://code.wireshark.org/review/29511
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 69e49ed9926153e2061951f7026f373a0e21b978)
    Reviewed-on: https://code.wireshark.org/review/29513
    

Actions performed:

    from  c6c0df1   [Automatic update for 2018-09-09]
     add  536fb94   Fix handling of invalid type values.


Summary of changes:
 epan/dissectors/packet-mswsp.c | 284 ++++++++++++++---------------------------
 1 file changed, 99 insertions(+), 185 deletions(-)