Wireshark-commits: [Wireshark-commits] master f4d2dff: Fix handling of invalid type values.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 09 Sep 2018 17:46:59 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f4d2dffd8be1df30a832647a2f188507076f0fed
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f4d2dff by Guy Harris (guy@xxxxxxxxxxxx):

    Fix handling of invalid type values.
    
    If vType_get_type() returns NULL, that means that the packet is bad, not
    that the dissector is bad.  Report it as such.
    
    Bug: 15119
    Change-Id: I8e66fcece2b526ef9edbf948862f8fc5bea25d74
    Reviewed-on: https://code.wireshark.org/review/29511
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  eeb71e7   CMake: Remove Qt specific code for warnings
     add  f4d2dff   Fix handling of invalid type values.


Summary of changes:
 epan/dissectors/packet-mswsp.c | 284 ++++++++++++++---------------------------
 1 file changed, 99 insertions(+), 185 deletions(-)