Wireshark-commits: [Wireshark-commits] master-2.6 0759402: Qt: fix wrong Follow Stream text positio
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 06 Jul 2018 12:14:36 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=07594029639439823ce488feedd95c33591d73fb
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

0759402 by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: fix wrong Follow Stream text position after changing mode
    
    When switching from ASCII to other modes (such as Hex), the previous
    text to packet number mapping was not cleared. This resulted in
    using the wrong packet number when hovering over the packet data.
    
    Change-Id: I29ba1786925490c33fc9181373a31d51f5091642
    Reviewed-on: https://code.wireshark.org/review/28614
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 7a3f397c2b746677f7f7e326b92bd9620b9a15dd)
    Reviewed-on: https://code.wireshark.org/review/28647
    Tested-by: Petri Dish Buildbot
    

Actions performed:

    from  e56148c   Follow Stream: ensure linear performance with many packets
    adds  0759402   Qt: fix wrong Follow Stream text position after changing mode


Summary of changes:
 ui/qt/follow_stream_dialog.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)