Wireshark-commits: [Wireshark-commits] master caa8efa: tests: add regression tests for Follow TCP S
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 06 Jul 2018 12:11:20 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=caa8efa0d2435c527bb947c3fb3f1b4a610ef515
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

caa8efa by Peter Wu (peter@xxxxxxxxxxxxx):

    tests: add regression tests for Follow TCP Stream
    
    Verified that the tests failed without the fixes for the linked bugs.
    The tests have full statement coverage(*1) for check_follow_fragments
    and follow_tcp_tap_listener. For details and Scapy script, see:
    https://git.lekensteyn.nl/peter/wireshark-notes/commit/crafted-pkt/badsegments.py?id=4ecf9d858b49e76d8a9c29df01ce1bd523ae6704
    
     (*1) except for `if (data_length <= data_offset) { data_length = 0; }`
    
    Change-Id: I625536df375272cf6c9116231194c39df1217fae
    Ping-Bug: 13700
    Ping-Bug: 14944
    Reviewed-on: https://code.wireshark.org/review/28618
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  11871be   Plug extension list leak.
    adds  caa8efa   tests: add regression tests for Follow TCP Stream


Summary of changes:
 CMakeLists.txt                     |   1 +
 test/captures/tcp-badsegments.pcap | Bin 0 -> 1732 bytes
 test/suite_follow.py               |  75 +++++++++++++++++++++++++++++++++++++
 3 files changed, 76 insertions(+)
 create mode 100644 test/captures/tcp-badsegments.pcap
 create mode 100644 test/suite_follow.py