Wireshark-commits: [Wireshark-commits] master-2.6 63f90a3: Rewrite make-{dissectors, taps} in Pytho
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 11 Jun 2018 18:02:09 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=63f90a302e5efd63a66b51fe8212e46aef6c8530
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

63f90a3 by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    Rewrite make-{dissectors,taps} in Python
    
    Having these build tools in machine code poses problems when cross-compiling.
    The most significant being that we need to find the host and build GLiB
    dependencies at compile-time.
    
    There is no noticeable speed difference between the Python and C implementation.
    
    Ping-Bug: 14622
    Change-Id: Id13f823c7f4abf51edfa291e703028873748989f
    Reviewed-on: https://code.wireshark.org/review/28130
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit 722d6b06f606bc045ecef6fe5c8f2c700a3dad65)
     [Peter: adjusted autotools to use the new make-regs.py script]
    Reviewed-on: https://code.wireshark.org/review/28204
    

Actions performed:

    from  605c095   Offer a permissions suggestion for macOS.
    adds  63f90a3   Rewrite make-{dissectors,taps} in Python


Summary of changes:
 .gitignore                      |   2 -
 CMakeLists.txt                  |   2 +-
 cmake/modules/UseMakeTaps.cmake |   4 +-
 epan/dissectors/CMakeLists.txt  |   4 +-
 epan/dissectors/Makefile.am     |   4 +-
 tools/CMakeLists.txt            |  32 ------
 tools/Makefile.am               |  16 ---
 tools/make-dissectors.c         | 215 ----------------------------------------
 tools/make-regs.py              | 127 ++++++++++++++++++++++++
 tools/make-taps.c               | 154 ----------------------------
 tools/pre-commit-ignore.conf    |   1 -
 ui/cli/Makefile.am              |   4 +-
 ui/gtk/Makefile.am              |   4 +-
 ui/qt/Makefile.am               |   4 +-
 14 files changed, 140 insertions(+), 433 deletions(-)
 delete mode 100644 tools/CMakeLists.txt
 delete mode 100644 tools/make-dissectors.c
 create mode 100755 tools/make-regs.py
 delete mode 100644 tools/make-taps.c