Wireshark-commits: [Wireshark-commits] master 722d6b0: Rewrite make-{dissectors, taps} in Python
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 11 Jun 2018 17:01:16 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=722d6b06f606bc045ecef6fe5c8f2c700a3dad65
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

722d6b0 by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    Rewrite make-{dissectors,taps} in Python
    
    Having these build tools in machine code poses problems when cross-compiling.
    The most significant being that we need to find the host and build GLiB
    dependencies at compile-time.
    
    There is no noticeable speed difference between the Python and C implementation.
    
    Ping-Bug: 14622
    Change-Id: Id13f823c7f4abf51edfa291e703028873748989f
    Reviewed-on: https://code.wireshark.org/review/28130
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  bfb7028   More shellcheck fixes.
    adds  722d6b0   Rewrite make-{dissectors,taps} in Python


Summary of changes:
 .gitignore                      |   2 -
 CMakeLists.txt                  |   2 +-
 cmake/modules/UseMakeTaps.cmake |   4 +-
 epan/dissectors/CMakeLists.txt  |   4 +-
 tools/CMakeLists.txt            |  32 --------
 tools/make-dissectors.c         | 161 ----------------------------------------
 tools/make-lib.c                |  89 ----------------------
 tools/make-lib.h                |  38 ----------
 tools/make-regs.py              | 127 +++++++++++++++++++++++++++++++
 tools/make-taps.c               | 122 ------------------------------
 tools/pre-commit-ignore.conf    |   1 -
 11 files changed, 132 insertions(+), 450 deletions(-)
 delete mode 100644 tools/CMakeLists.txt
 delete mode 100644 tools/make-dissectors.c
 delete mode 100644 tools/make-lib.c
 delete mode 100644 tools/make-lib.h
 create mode 100755 tools/make-regs.py
 delete mode 100644 tools/make-taps.c