Wireshark-commits: [Wireshark-commits] master de6f605: CIP: Remove extra tree level from path segme
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 03 Jun 2018 05:56:38 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=de6f6056f19301a1b9e09c7094328bfc8e18f380
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

de6f605 by Dylan Ulis (daulis0@xxxxxxxxx):

    CIP: Remove extra tree level from path segments
    
    There was an extra level of indentation in the tree structure that didn't
    add any value.
    This tree node just displayed the same text that it's parent tree did.
    
    Just remove this to make things easier to navigate.
    
    See feature_cip_all_segments.pcap from
    Bug: 12049
    
    Change-Id: Ia51f0f66b1ea0aefaa4d016335c0d5e8515a2c30
    Reviewed-on: https://code.wireshark.org/review/27958
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  045f2aa   sharkd_session.c: fix a size_t to int conversion warning emitted by MSVC2017 x64
    adds  de6f605   CIP: Remove extra tree level from path segments


Summary of changes:
 epan/dissectors/packet-cip.c | 156 +++++++++++++++++--------------------------
 1 file changed, 60 insertions(+), 96 deletions(-)