Wireshark-commits: [Wireshark-commits] master-2.2 2310277: Give details for all cases where the off
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 03 Jun 2018 03:05:15 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=23102775abd397d12ae908612136960195da7cc5
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

2310277 by Guy Harris (guy@xxxxxxxxxxxx):

    Give details for all cases where the offset overflows.
    
    It *does* appear to be overflowing, but it's not obvious how that would
    happen...
    
    ...unless tvb_find_guint8(), called from tvb_strsize(), somehow doesn't
    stop at the end of the tvbuff, keeps scanning until it finally finds a
    '\0', and that somehow causes a problem.
    
    Change-Id: If292786904e7ab6e3db483cd4084fd4264f20b58
    Reviewed-on: https://code.wireshark.org/review/27974
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 9ea8145e80ecca952890f353a0c658fb028c2aa8)
    Reviewed-on: https://code.wireshark.org/review/27975
    

Actions performed:

    from  b5c0c1d   Print the dissector bug message if WIRESHARK_ABORT_ON_DISSECTOR_BUG is set.
    adds  2310277   Give details for all cases where the offset overflows.


Summary of changes:
 epan/dissectors/packet-mmse.c | 204 +++++++++++++++++++++++++++++++++++-------
 1 file changed, 170 insertions(+), 34 deletions(-)