Wireshark-commits: [Wireshark-commits] master 30ebff3: Qt: use data() instead of constData() in pca
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 30 May 2018 08:42:23 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=30ebff35e39c6c20f0c3caf706edfa9be16faf00
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

30ebff3 by Dario Lombardo (lomato@xxxxxxxxx):

    Qt: use data() instead of constData() in pcap_compile().
    
    In different versions of libpcap, pcap_compile() has a 3rd parameter
    with or without const. Using a non-const variable, allow the auto
    promotion to const possible, but not the vice-versa.
    
    Fixes compilation on OpenBSD.
    
    Change-Id: I72162a4ea419668b6222e84bf5525a6c48fddd52
    Reviewed-on: https://code.wireshark.org/review/27896
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  06571ad   Add valgrind support to randpkt-test.sh.
    adds  30ebff3   Qt: use data() instead of constData() in pcap_compile().


Summary of changes:
 ui/qt/capture_filter_syntax_worker.cpp | 4 ++--
 ui/qt/compiled_filter_output.cpp       | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)