Wireshark-commits: [Wireshark-commits] master 06571ad: Add valgrind support to randpkt-test.sh.
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=06571ad3303ffaceadb634713e3245b0fa995b4b
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
06571ad by Darius Davis (darius@xxxxxxxxxx):
Add valgrind support to randpkt-test.sh.
There's already valgrind support in fuzz-test.sh; This change simply clones the
relevant fragments of script into randpkt-test.sh, making very minor tweaks as
needed. Valgrind support in randpkt-test.sh is enabled through the "-g"
command-line option, just like with fuzz-test.sh.
In my testing here, it seems MAX_LEAK could be reduced somewhat, but I don't
think that that belongs as part of this change; I've simply kept the MAX_LEAK
value from fuzz-test.sh.
While we're here, the last line of valgrind-wireshark.sh launches a subprocess,
and that shell then simply returns its exit code, so there is no need for the
shell to stick around. So, let's use "exec" here to replace the shell with the
new process.
Testing Done: On Linux amd64, ran several iterations of randpkt-test.sh and
fuzz-test.sh, both with and without the "-g" option.
Change-Id: I87cc63559dc2e66c42c905f46657ce40cabf0104
Reviewed-on: https://code.wireshark.org/review/27741
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 8da4777 Qt: fix memleaks on opening a context menu
adds 06571ad Add valgrind support to randpkt-test.sh.
Summary of changes:
tools/randpkt-test.sh | 68 +++++++++++++++++++++++++++++++++++----------
tools/valgrind-wireshark.sh | 2 +-
2 files changed, 55 insertions(+), 15 deletions(-)
