Wireshark · Wireshark-commits: [Wireshark-commits] master-2.2 ab8a33e: tvbuff: make tvb_bytes_exist fail with negative values

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ab8a33ef083b9732c89117747a83a905a676faf6
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

ab8a33e by Peter Wu (peter@xxxxxxxxxxxxx):

    tvbuff: make tvb_bytes_exist fail with negative values
    
    tvb_generic_clone_offset_len uses tvb_bytes_exist to check that the
    requested tvb data is actually available. It did not expect negative
    values, that would result in an overly large memory allocation.
    
    Bug: 14678
    Change-Id: Ie80095a381e55ca5dbbd5c9d835243549d0b212e
    Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=7179
    Reviewed-on: https://code.wireshark.org/review/27526
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit d80acae40d14efeb857258ca923637b590dd6be9)
    Reviewed-on: https://code.wireshark.org/review/27535
    

Actions performed:

    from  4425716   dns: fix null pointer deref for empty name in SRV record
    adds  ab8a33e   tvbuff: make tvb_bytes_exist fail with negative values


Summary of changes:
 epan/tvbuff.c | 7 +++++++
 1 file changed, 7 insertions(+)