Wireshark-commits: [Wireshark-commits] master-2.4 ac55e80: tvbuff: make tvb_bytes_exist fail with n
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 14 May 2018 13:35:13 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ac55e80ae466e9dc5ec94dbb0ec0aa7a1f89e918
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

ac55e80 by Peter Wu (peter@xxxxxxxxxxxxx):

    tvbuff: make tvb_bytes_exist fail with negative values
    
    tvb_generic_clone_offset_len uses tvb_bytes_exist to check that the
    requested tvb data is actually available. It did not expect negative
    values, that would result in an overly large memory allocation.
    
    Bug: 14678
    Change-Id: Ie80095a381e55ca5dbbd5c9d835243549d0b212e
    Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=7179
    Reviewed-on: https://code.wireshark.org/review/27526
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit d80acae40d14efeb857258ca923637b590dd6be9)
    Reviewed-on: https://code.wireshark.org/review/27534
    

Actions performed:

    from  95c884e   dns: fix null pointer deref for empty name in SRV record
    adds  ac55e80   tvbuff: make tvb_bytes_exist fail with negative values


Summary of changes:
 epan/tvbuff.c | 7 +++++++
 1 file changed, 7 insertions(+)