Wireshark-commits: [Wireshark-commits] master 064c09a: Qt: fix memleak of profile name on copying a
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 09 May 2018 18:41:44 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=064c09a293ea044baa4a06eb682b2e8e046fe0e2
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

064c09a by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: fix memleak of profile name on copying a profile
    
    add_to_profile_list (via add_profile_entry) clones the name and does not
    own it, so free it afterwards. Found by Clang Static Analyzer.
    
    Change-Id: I340c91b65d97b24a52812fd6f4b85933cfb15f89
    Reviewed-on: https://code.wireshark.org/review/27343
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  e7d24c6   Always explicitly set tm_isdst before calling mktime().
    adds  064c09a   Qt: fix memleak of profile name on copying a profile


Summary of changes:
 ui/qt/profile_dialog.cpp | 1 +
 1 file changed, 1 insertion(+)