Wireshark · Wireshark-commits: [Wireshark-commits] master-2.2 afc9786: Always explicitly set tm_isdst before calling mktime().

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=afc9786f031fc847b19923b93c0c929137c06c83
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

afc9786 by Guy Harris (guy@xxxxxxxxxxxx):

    Always explicitly set tm_isdst before calling mktime().
    
    Except in rare cases, we want to set it to -1 so that we let mktime()
    determine whether DST/Summer Time was in effect at the given date and
    time rather than pretending that we know whether it's in effect or not.
    
    Change-Id: I0ea75317dd308a515cedf4d1260b583e1592cc9b
    Reviewed-on: https://code.wireshark.org/review/27431
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit e7d24c606cdb460e835f7d7553d7b82e1ee11eac)
    Reviewed-on: https://code.wireshark.org/review/27434
    

Actions performed:

    from  4730856   proto: don't overrun buffer.
    adds  afc9786   Always explicitly set tm_isdst before calling mktime().


Summary of changes:
 editcap.c             | 1 +
 ui/time_shift.c       | 1 +
 wiretap/logcat_text.c | 1 +
 3 files changed, 3 insertions(+)