Wireshark-commits: [Wireshark-commits] master ca9976b: rsa: fix memleak and accept keys from certai
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 21 Mar 2018 10:36:33 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ca9976bec95234504b96ee9b2649fd791b06cc20
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ca9976b by Peter Wu (peter@xxxxxxxxxxxxx):

    rsa: fix memleak and accept keys from certain PKCS#12 files
    
    The "bag" was not deallocated when the key is successfully loaded.
    Parse all bag elements rather than clearing the bag after the first
    iteration (this restores previous behavior).
    
    Change-Id: Ib52da6586f7435d18fa5b0660e7771436544b634
    Fixes: v2.5.0rc0-613-gf63b68f707 ("Further cleanups.")
    Reviewed-on: https://code.wireshark.org/review/26481
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  af8ac43   tcp: preserve data source if a PDU uses it
    adds  ca9976b   rsa: fix memleak and accept keys from certain PKCS#12 files


Summary of changes:
 wsutil/rsa.c | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)