Wireshark-commits: [Wireshark-commits] master af8ac43: tcp: preserve data source if a PDU uses it
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 21 Mar 2018 10:35:33 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=af8ac43a1fc7a67d54bb2734244ea12194842fa9
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

af8ac43 by Peter Wu (peter@xxxxxxxxxxxxx):

    tcp: preserve data source if a PDU uses it
    
    If the previous TCP segments already form one or more PDUs, then the
    data source of these segments must not be removed. Otherwise
    get_field_data (epan/print.c) will fail to find the data source which
    correspond to the fields within these PDUs.
    
    Also tested with the capture referenced in v1.11.3-rc1-1525-g21e0a63b29
    (bug 9169), the "tshark -Vr mem-leak.pcap" output remains unchanged.
    
    Bug: 14472
    Change-Id: Ia448a6b84dd2eb84b00e56d3fcde04f7bec05b9d
    Reviewed-on: https://code.wireshark.org/review/26397
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  10c508e   packet-wsp: fixed incorrect invalid header handling
    adds  af8ac43   tcp: preserve data source if a PDU uses it


Summary of changes:
 epan/dissectors/packet-tcp.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)