Wireshark-commits: [Wireshark-commits] master-2.4 e0aba0d: Just use tvb_memeql() to check the signa
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 23 Feb 2018 05:23:09 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e0aba0de8e9a67566ba164a057976bb8f4f8074b
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

e0aba0d by Guy Harris (guy@xxxxxxxxxxxx):

    Just use tvb_memeql() to check the signature.
    
    That's one of the things it's intended to do - check the values of parts
    of the packet that might not actually be there.  The comparison fails if
    either 1) it's all there and doesn't match or 2) it's not all there.
    
    Change-Id: I0f97ea5f75c2cada511e254ec096d294ea710f45
    Reviewed-on: https://code.wireshark.org/review/26040
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 017167fb34220a17af361d50b2d239927acac7c1)
    Reviewed-on: https://code.wireshark.org/review/26041
    

Actions performed:

    from  268fae4   Get rid of the -sdkroot option; it doesn't affect anything.
    adds  e0aba0d   Just use tvb_memeql() to check the signature.


Summary of changes:
 epan/dissectors/packet-ns-rpc.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)