Wireshark-commits: [Wireshark-commits] master 017167f: Just use tvb_memeql() to check the signature
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 23 Feb 2018 05:22:05 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=017167fb34220a17af361d50b2d239927acac7c1
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

017167f by Guy Harris (guy@xxxxxxxxxxxx):

    Just use tvb_memeql() to check the signature.
    
    That's one of the things it's intended to do - check the values of parts
    of the packet that might not actually be there.  The comparison fails if
    either 1) it's all there and doesn't match or 2) it's not all there.
    
    Change-Id: I0f97ea5f75c2cada511e254ec096d294ea710f45
    Reviewed-on: https://code.wireshark.org/review/26040
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  86f329a   LTE MAC: check direction and lcid before looking up msg3 table
    adds  017167f   Just use tvb_memeql() to check the signature.


Summary of changes:
 epan/dissectors/packet-ns-rpc.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)