Wireshark-commits: [Wireshark-commits] master-2.4 20c3af2: NSRPC: fix heuristic dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 07 Feb 2018 18:32:53 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=20c3af216f45bbaa7abfe13e2332dc1b7e846eae
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

20c3af2 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    NSRPC: fix heuristic dissector
    
    Do not check reported length but captured length, otherwise it can
    can trigger an exception when trying to fetch at offset 4.
    Once the (very basic heuristic) is verified, cann the right dissection
    function.
    
    Bug: 14399
    Change-Id: Ie09d80e04f2501c940693a2ea9ecbd2f84d1e22f
    Reviewed-on: https://code.wireshark.org/review/25666
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 80a1dd70295ce06d55ba1b9e7b58647c74ae77c0)
    Reviewed-on: https://code.wireshark.org/review/25667
    

Actions performed:

    from  af59431   FCP: Add NULL check to prevent crash.
    adds  20c3af2   NSRPC: fix heuristic dissector


Summary of changes:
 epan/dissectors/packet-ns-rpc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)