Wireshark-commits: [Wireshark-commits] master 80a1dd7: NSRPC: fix heuristic dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 07 Feb 2018 18:31:28 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=80a1dd70295ce06d55ba1b9e7b58647c74ae77c0
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

80a1dd7 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    NSRPC: fix heuristic dissector
    
    Do not check reported length but captured length, otherwise it can
    can trigger an exception when trying to fetch at offset 4.
    Once the (very basic heuristic) is verified, cann the right dissection
    function.
    
    Bug: 14399
    Change-Id: Ie09d80e04f2501c940693a2ea9ecbd2f84d1e22f
    Reviewed-on: https://code.wireshark.org/review/25666
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  2282447   wsutil: Allow NULL as profile name
    adds  80a1dd7   NSRPC: fix heuristic dissector


Summary of changes:
 epan/dissectors/packet-ns-rpc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)