Wireshark · Wireshark-commits: [Wireshark-commits] master-2.4 824bc65: Clean up addition of FT_IPv{4, 6} fields.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=824bc65623e069b10f5b517223b33ab2282c93af
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

824bc65 by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up addition of FT_IPv{4,6} fields.
    
    The data for an address is *not* guaranteed to be aligned on any
    particular boundary, so, for IPv4 addresses, don't assume it's aligned
    on a 32-bit boundary - copy it with memcpy() and use the result of the
    copy.
    
    For IPv6 addresses, cast the data pointer to a pointer to a *const*
    struct e_in6_addr, so we don't throw away constness.
    
    Change-Id: I0e00263f594d7778c3bd9b98e4336cb201c1f3d5
    Reviewed-on: https://code.wireshark.org/review/25580
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit ebb471f2116494f2c56124b03a5f21818e8cc71b)
    Reviewed-on: https://code.wireshark.org/review/25581
    

Actions performed:

    from  24c648d   Qt: Keep auto-scroll when starting a new capture
    adds  824bc65   Clean up addition of FT_IPv{4,6} fields.


Summary of changes:
 epan/wslua/wslua_tree.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)