Wireshark-commits: [Wireshark-commits] master ebb471f: Clean up addition of FT_IPv{4, 6} fields.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 03 Feb 2018 21:16:17 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ebb471f2116494f2c56124b03a5f21818e8cc71b
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ebb471f by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up addition of FT_IPv{4,6} fields.
    
    The data for an address is *not* guaranteed to be aligned on any
    particular boundary, so, for IPv4 addresses, don't assume it's aligned
    on a 32-bit boundary - copy it with memcpy() and use the result of the
    copy.
    
    For IPv6 addresses, cast the data pointer to a pointer to a *const*
    ws_in6_addr, so we don't throw away constness.
    
    Change-Id: I0e00263f594d7778c3bd9b98e4336cb201c1f3d5
    Reviewed-on: https://code.wireshark.org/review/25580
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  d5f52cf   Don't link wiretap plugins with libwireshark.
    adds  ebb471f   Clean up addition of FT_IPv{4,6} fields.


Summary of changes:
 epan/wslua/wslua_tree.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)