Wireshark · Wireshark-commits: [Wireshark-commits] master-2.0 6a0164d: Improve the display of metrics.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6a0164dc296067545ea47164b595fc8948faf631
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

6a0164d by Guy Harris (guy@xxxxxxxxxxxx):

    Improve the display of metrics.
    
    Give the value and the "supported" bit names that reflect what they are.
    
    Show both the "supported" bit and the value as bitfields, because that's
    what they are.
    
    Show the "supported" bit before the value.
    
    Show the metric value as decimal; there's nothing particularly
    hexadecimal about it.
    
    The "supported" bit is 1 if it's *not* supported and 0 if it *is*
    supported.
    
    Fetch the byte for the metric within dissect_metric(), rather than in
    the call to dissect_metric().
    
    Change-Id: Ief3bb74b273df06e07066ccdede38a2eeedc6db2
    Reviewed-on: https://code.wireshark.org/review/20836
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit ebcfc1ba8e85bd37b03f8ae5fd2f48ce07239bca)
    Reviewed-on: https://code.wireshark.org/review/20838
    

Actions performed:

    from  0d28bc3   Don't add an FT_UINT32 with proto_tree_add_none_format().
    adds  6a0164d   Improve the display of metrics.


Summary of changes:
 epan/dissectors/packet-isis-lsp.c |   78 +++++++++++++++++++++----------------
 1 file changed, 45 insertions(+), 33 deletions(-)