Wireshark-commits: [Wireshark-commits] master-2.2 21d8c7a: Improve the display of metrics.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 1 Apr 2017 06:35:30 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=21d8c7aece0cce73a5b74ac6af54798b1f3d34e1
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

21d8c7a by Guy Harris (guy@xxxxxxxxxxxx):

    Improve the display of metrics.
    
    Give the value and the "supported" bit names that reflect what they are.
    
    Show both the "supported" bit and the value as bitfields, because that's
    what they are.
    
    Show the "supported" bit before the value.
    
    Show the metric value as decimal; there's nothing particularly
    hexadecimal about it.
    
    The "supported" bit is 1 if it's *not* supported and 0 if it *is*
    supported.
    
    Fetch the byte for the metric within dissect_metric(), rather than in
    the call to dissect_metric().
    
    Change-Id: Ief3bb74b273df06e07066ccdede38a2eeedc6db2
    Reviewed-on: https://code.wireshark.org/review/20836
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit ebcfc1ba8e85bd37b03f8ae5fd2f48ce07239bca)
    Reviewed-on: https://code.wireshark.org/review/20837
    

Actions performed:

    from  88c3e3a   Don't add an FT_UINT32 with proto_tree_add_none_format().
    adds  21d8c7a   Improve the display of metrics.


Summary of changes:
 epan/dissectors/packet-isis-lsp.c |   78 +++++++++++++++++++++----------------
 1 file changed, 45 insertions(+), 33 deletions(-)