Wireshark-commits: [Wireshark-commits] master-2.2 b7e68c4: Decode TBCD strings in GSM MAP as per th
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 13 Jan 2017 07:18:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b7e68c4e2af9b89d8bcc6befa85a67f6e604646d
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

b7e68c4 by Guy Harris (guy@xxxxxxxxxxxx):

    Decode TBCD strings in GSM MAP as per the GSM MAP spec.
    
    Hex digits 0xa through 0xe are '*', '#', 'a', 'b', and 'c',
    respectively.
    
    Constify the dgt_set_t argument to tvb_bcd_dig_to_wmem_packet_str(),
    while we're at it.
    
    Bug: 13316
    Change-Id: I7586f35d23fd262453779d99946e7ccad4b6ffab
    Reviewed-on: https://code.wireshark.org/review/19620
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit c303679d999f38d92a00f0cf99ba0a000a9ff92f)
    Reviewed-on: https://code.wireshark.org/review/19621
    

Actions performed:

    from  ab36584   Revert "Qt: check NULL before dereference (CID 1394324)"
    adds  b7e68c4   Decode TBCD strings in GSM MAP as per the GSM MAP spec.


Summary of changes:
 epan/dissectors/asn1/gsm_map/gsm_map.cnf |    9 ++-
 epan/dissectors/packet-gsm_map.c         |   95 ++++++++++++++++--------------
 epan/tvbuff.c                            |    4 +-
 epan/tvbuff.h                            |    3 +-
 4 files changed, 63 insertions(+), 48 deletions(-)