Wireshark-commits: [Wireshark-commits] master c303679: Decode TBCD strings in GSM MAP as per the GS
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 13 Jan 2017 07:16:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c303679d999f38d92a00f0cf99ba0a000a9ff92f
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c303679 by Guy Harris (guy@xxxxxxxxxxxx):

    Decode TBCD strings in GSM MAP as per the GSM MAP spec.
    
    Hex digits 0xa through 0xe are '*', '#', 'a', 'b', and 'c',
    respectively.
    
    Constify the dgt_set_t argument to tvb_bcd_dig_to_wmem_packet_str(),
    while we're at it.
    
    Bug: 13316
    Change-Id: I7586f35d23fd262453779d99946e7ccad4b6ffab
    Reviewed-on: https://code.wireshark.org/review/19620
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  a4bbd3c   packet-infiniband: Pass read request packets to ULP dissectors
    adds  c303679   Decode TBCD strings in GSM MAP as per the GSM MAP spec.


Summary of changes:
 epan/dissectors/asn1/gsm_map/gsm_map.cnf |    9 ++-
 epan/dissectors/packet-gsm_map.c         |   95 ++++++++++++++++--------------
 epan/tvbuff.c                            |    4 +-
 epan/tvbuff.h                            |    3 +-
 4 files changed, 63 insertions(+), 48 deletions(-)