Wireshark-commits: [Wireshark-commits] master 78d56e5: Cleanup transum post-dissector.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 25 Dec 2016 08:07:22 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=78d56e5dd74ca22bbfbbf94ba8a74becc15b23d3
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

78d56e5 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Cleanup transum post-dissector.
    
    1. Enable/disable preference not needed - just use Enabled Protocol
    dialog interface.  Added support for backwards compatibility of preference.
    2. Add value_string for calculation values
    3. Create an structured array of "hfs of interest" so they can more easily
    be extended.
    4. Convert a bunch of arrays into hash tables and lists.  For the amount
    of wasted space they were taking up, we can live with the very slight
    performance degrade.  Also puts less limits on number of things to process.
    
    Change-Id: I7399789d62432b507062ed9cdc20ad974b9dde1b
    Reviewed-on: https://code.wireshark.org/review/19406
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  2563503   Support all MA modes, fix BB CRC and frag edge cases
    adds  78d56e5   Cleanup transum post-dissector.


Summary of changes:
 epan/prefs.c                     |   32 ++
 plugins/transum/decoders.c       |  231 ++++++-----
 plugins/transum/decoders.h       |   12 +-
 plugins/transum/packet-transum.c |  849 ++++++++++++++++----------------------
 plugins/transum/packet-transum.h |   81 ++--
 plugins/transum/preferences.h    |    6 +-
 6 files changed, 546 insertions(+), 665 deletions(-)