Wireshark-commits: [Wireshark-commits] master 2563503: Support all MA modes, fix BB CRC and frag ed
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2563503301aa4321a9a7a1ed392c9cbbe147fd2f
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
2563503 by MustBeArt (paul@xxxxxxxxxxxxx):
Support all MA modes, fix BB CRC and frag edge cases
Support all four mode adaptation interface formats. Add a user preference to
specify which format is in use, or to request that the format be guessed.
Guessing is improved, but can never be reliable.
Fix problem with baseband header CRC check that caused almost all packets to
show a spurious CRC error, introduced with proto_tree_add_checksum.
Fix problem with GSE PDU fragmentation CRC beginning in one fragment and
ending in another. Any GSE frames following the fragment containing the
end of the CRC would be parsed at the wrong offset.
Fix problem with IPv4 or IPv6 starting exactly on a fragmentation boundary,
so that one baseband frame contains the complete GSE header but zero bytes
of the IP payload. Trying to further dissect the zero-length payload led to
a "malformed packet" display.
Standardize spelling per governing document: adaption -> adaptation
Change-Id: I69e64e74e4b4f02515411471e1d76b0eeb02fef1
Reviewed-on: https://code.wireshark.org/review/19421
Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 802362e Avoid recursive scan_local_interfaces operation
adds 2563503 Support all MA modes, fix BB CRC and frag edge cases
Summary of changes:
epan/dissectors/packet-dvb-s2-bb.c | 260 ++++++++++++++++++++++++------------
1 file changed, 175 insertions(+), 85 deletions(-)
