Wireshark-commits: [Wireshark-commits] master e2c26ff: Don't use a local variable's address in set_
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 7 Dec 2016 22:22:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e2c26ff90c6aee381c3af0c33253dcfa5631bb43
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e2c26ff by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use a local variable's address in set_address().
    
    The address data is supposed to outlive the current routine's scope, so
    you can't pass it a pointer to an argument to the routine; you have to
    allocate pinfo-scoped memory and copy the variable to that.
    
    Bug: 13219
    Change-Id: Id3fdb52b614036d4d24d0676e798a2524fbe916c
    Reviewed-on: https://code.wireshark.org/review/19136
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  37eead0   Revert "Temporarily break up complicated expression into a bunch of separate ifs."
    adds  e2c26ff   Don't use a local variable's address in set_address().


Summary of changes:
 epan/dissectors/packet-infiniband.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)