Wireshark-commits: [Wireshark-commits] master 37eead0: Revert "Temporarily break up complicated exp
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 7 Dec 2016 21:59:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=37eead0f603e8129702384a0798410d6c0b0884b
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

37eead0 by Peter Wu (peter@xxxxxxxxxxxxx):

    Revert "Temporarily break up complicated expression into a bunch of separate ifs."
    
    This reverts commit db7c6286169015a727024e86eb270722127125bb.
    
    As pointed out in bug 13044, the warning is really coming from checking
    "cops_call->solicited", no need to expand the whole expression.
    
    Ping-Bug: 13044
    Change-Id: Ib376ce6d0ec9fcf896e6081adae7664f19d9f759
    Reviewed-on: https://code.wireshark.org/review/19115
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  49fcee3   Qt: don't append a second extension to save file names
    adds  37eead0   Revert "Temporarily break up complicated expression into a bunch of separate ifs."


Summary of changes:
 epan/dissectors/packet-cops.c |   63 -----------------------------------------
 1 file changed, 63 deletions(-)