Wireshark-commits: [Wireshark-commits] master 26e883a: Move Base32_encode from packet-fc00.c to wsu
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 2 Nov 2016 04:35:10 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=26e883a75c37e18f633e47dcd85e2648ee1f03ae
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

26e883a by Michael Mann (mmann78@xxxxxxxxxxxx):

    Move Base32_encode from packet-fc00.c to wsutil (as ws_base32_decode)
    
    There could be some reuse out of it, so but it with the rest of the
    general utilities.
    
    Change-Id: I404c135b933660a82678510b9ca2701985c5632a
    Reviewed-on: https://code.wireshark.org/review/18589
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8ba444b   packet-infiniband: Fixed IP based connections & other minor fixes
    adds  26e883a   Move Base32_encode from packet-fc00.c to wsutil (as ws_base32_decode)


Summary of changes:
 debian/libwsutil0.symbols        |    1 +
 epan/dissectors/packet-fc00.c    |   47 ++----------------------
 wsutil/CMakeLists.txt            |    1 +
 wsutil/Makefile.am               |    2 ++
 wsutil/{base64.c => base32.c}    |   74 ++++++++++++++++++++------------------
 ui/language.h => wsutil/base32.h |   27 +++++++-------
 6 files changed, 60 insertions(+), 92 deletions(-)
 copy wsutil/{base64.c => base32.c} (52%)
 copy ui/language.h => wsutil/base32.h (66%)