Wireshark · Wireshark-commits: [Wireshark-commits] master 8ba444b: packet-infiniband: Fixed IP based connections & other minor fixe

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8ba444b8438395efe352da8c66dd64e9449c60bb
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8ba444b by Parav Pandit (paravpandit@xxxxxxxxx):

    packet-infiniband: Fixed IP based connections & other minor fixes
    
    1. Fixed setting right address type instead of AT_IB for RoCE and RRoCE
    depending on address type given by pinfo where address type would be
    IPv4 or IPV6.
    Fail to do so was resulting into infiniband dissector adding
    conversation info based on AT_IB type vs payload dissectors dissecting
    based on pinfo. Fixing this allows to add/search based on right
    address type.
    (Tested for Infiniband and RRoCE)
    
    2. Added support to pass already parsed CM attribute id from infiniand to
    other mad private data dissectors so that right dissection of private data
    can be done based on CM attribute id (message type).
    Moved CM attribute id definitions to header file so that private data
    dissectors based on CM attribute id can reuse these values without
    duplicate defines.
    (Tested for Infiniband and RRoCE)
    
    3. Added direction client to server/server to client, (active/passive) to
    conversation_data for payload dissectors which cannot dissect only based
    on payload content without knowing the direction.
    (Tested for RRoCE)
    
    4. Fixed IP CM to claim all 92 bytes of private data (including consumer
    private data), instead of just 36 bytes of header because its part of IP
    CM private data.
    (Tested for Infiniband and RRoCE)
    
    5. Fixed MAD header to claim all 232 (256-24) bytes of data as it belongs
    to it in the tree.
    (Tested for Infiniband and RRoCE)
    
    6. Fixed getting ip version by performing AND operation first to extract IP
    version field.
    (Tested for RRoCE-IPV4 and Infiniband)
    
    Change-Id: I37daca6a089784b61c25e10cdc8f3cf028ca8c58
    Tested-by: paravpandit@xxxxxxxxx
    Reviewed-on: https://code.wireshark.org/review/18573
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  b0eac84   Small fixes for JSON output
    adds  8ba444b   packet-infiniband: Fixed IP based connections & other minor fixes


Summary of changes:
 epan/dissectors/packet-infiniband.c |  190 +++++++++++++++++++++++------------
 epan/dissectors/packet-infiniband.h |   10 ++
 2 files changed, 133 insertions(+), 67 deletions(-)