Wireshark-commits: [Wireshark-commits] master 763a059: extcap_example.py: fix hang on exit
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 16 Oct 2016 22:46:08 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=763a059fe967b5be4db4ca7b07279ae990a07c7d
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

763a059 by Peter Wu (peter@xxxxxxxxxxxxx):

    extcap_example.py: fix hang on exit
    
    I guess that when SIGINT is intercepted, then the writes are restarted
    and the doExit condition is never checked. Remove this racy check in
    favor of catching the KeyboardInterrupt exception.
    
    Test: tshark -i example1; kill tshark; check process list for python.
    
    Bug: 11657
    Change-Id: Ia8b1ee560b9dcd31dd91df27fbfb8e91237581c9
    Reviewed-on: https://code.wireshark.org/review/18218
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  2176423   extcap_example.py: fixes for Python 3
    adds  763a059   extcap_example.py: fix hang on exit


Summary of changes:
 doc/extcap_example.py |   61 ++++++++++++++++---------------------------------
 1 file changed, 20 insertions(+), 41 deletions(-)