Wireshark-commits: [Wireshark-commits] master 2176423: extcap_example.py: fixes for Python 3
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 16 Oct 2016 22:45:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2176423b4ab5ddb5b23d9bfd1417c7280b3f5129
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2176423 by Peter Wu (peter@xxxxxxxxxxxxx):

    extcap_example.py: fixes for Python 3
    
    Fixes trivial syntax error in try/except, ensure that the message are
    bytes instead of a string and remove unnecessary use of an append_bytes
    function.
    
    Did not try to fix the other Python issues, at least it runs now.
    
    Change-Id: Ib24f6116bc9d3cf177bc940da9f89aff90695a93
    Reviewed-on: https://code.wireshark.org/review/18212
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  7b06095   CIP: no previous prototype for ‘dissect_cip_attribute’ [-Wmissing-prototypes]
    adds  2176423   extcap_example.py: fixes for Python 3


Summary of changes:
 doc/extcap_example.py |   69 +++++++++++++++++++++++--------------------------
 1 file changed, 32 insertions(+), 37 deletions(-)