Wireshark-commits: [Wireshark-commits] master ba981ac: wsutil: add string to integer conversion uti
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 5 Sep 2016 09:54:37 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ba981aced8c64ff405cd42b071264e2d9791444a
Submitter: Dario Lombardo (lomato@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ba981ac by Dario Lombardo (lomato@xxxxxxxxx):

    wsutil: add string to integer conversion utilities.
    
    In the current code many functions have been used for convertion
    (strtol, atoi, g_ascii_strtoll, etc). Those utilities want to be
    the only, shared, way to convert integers.
    
    Change-Id: I22ba1bf54e144e73a4728612a4437de5a2d339e2
    Reviewed-on: https://code.wireshark.org/review/17414
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    

Actions performed:

    from  87519e4   S1AP: fix dissection of TransportLayerAddress IE when it contains both IPv4 and IPv6
    adds  ba981ac   wsutil: add string to integer conversion utilities.


Summary of changes:
 wsutil/CMakeLists.txt            |    1 +
 wsutil/Makefile.am               |    2 +
 wsutil/strtoi.c                  |  122 ++++++++++++++++++++++++++++++++++++++
 wsutil/{interface.h => strtoi.h} |   35 +++++++----
 4 files changed, 150 insertions(+), 10 deletions(-)
 create mode 100644 wsutil/strtoi.c
 copy wsutil/{interface.h => strtoi.h} (50%)