Wireshark · Wireshark-commits: [Wireshark-commits] master-2.2 ae6ae02: ERF: Fix dissector abort on short meta tags and typos

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ae6ae02feba7b353dc03f691e7a43205f6bc55dc
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

ae6ae02 by Anthony Coddington (anthony.coddington@xxxxxxxxxx):

    ERF: Fix dissector abort on short meta tags and typos
    
    Fix dissector abort on short tags.
    Fix value typo in hash mode enum.
    Differentiate unexpectedly short value, zero length (deliberate invalid)
    and off-end-of-record tags through expertinfo.
    Continue to use proto_tree_add_*() length mismatch warnings for unxepectedly
    long tags for now.
    Change WWN tags to FT_BYTES for now as they are 16 not 8 byte WWN. Not
    currently implemented outside Wireshark anyway.
    
    Ping-Bug: 12303
    Change-Id: I79fe4332f0c1f2aed726c69acdbc958eb9e08816
    Reviewed-on: https://code.wireshark.org/review/17382
    Reviewed-by: Anthony Coddington <anthony.coddington@xxxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit e2b0aa21ea0f5ed136e802546c9861f2e2609fd0)
    Reviewed-on: https://code.wireshark.org/review/17494
    

Actions performed:

    from  0aebbc3   S1AP: fix dissection of TransportLayerAddress IE when it contains both IPv4 and IPv6
    adds  ae6ae02   ERF: Fix dissector abort on short meta tags and typos


Summary of changes:
 epan/dissectors/packet-erf.c |  144 +++++++++++++++++++++++++++++++-----------
 1 file changed, 107 insertions(+), 37 deletions(-)