Wireshark-commits: [Wireshark-commits] master-2.2 5c07723: Fix IKEv1 decryption and initialization
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5c077233f63707c3732271b7b06e6b86181a4966
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark
Commits:
5c07723 by Mirko Parthey (mirko.parthey@xxxxxx):
Fix IKEv1 decryption and initialization vectors
Generate initialization vectors during Wireshark's first pass,
in order to improve reliability and efficiency. (bug #12699)
Remove a dissection shortcut in first pass to allow early analysis
of the transform payloads, which is needed to find out the crypto
algorithms.
Introduce a hash table to store an IV per message ID. (bug #12610)
Fix handling of the initial phase 1 IV. (bug #12620)
Cache IVs as per-packet data instead of a list.
Use the wmem allocator to avoid memory leaks.
Ensure libgcrypt resource cleanup on error paths.
Rely only on IKE attributes to find the decryption algorithm,
do not consider the length of the user-configured secret at this point.
Split code into small functions.
Ping-Bug: 12610
Ping-Bug: 12620
Ping-Bug: 12699
Change-Id: I7137943da42d54816808312cd1716a7e05478cbb
Reviewed-on: https://code.wireshark.org/review/16846
Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
(cherry picked from commit 561a2f056bd76bfcb4f89a05542ffce32eed5049)
Reviewed-on: https://code.wireshark.org/review/17198
Reviewed-by: Mirko Parthey <mirko.parthey@xxxxxx>
Actions performed:
from fef8471 ISAKMP: fix DOI field read size
adds 5c07723 Fix IKEv1 decryption and initialization vectors
Summary of changes:
epan/dissectors/packet-isakmp.c | 404 +++++++++++++++++++++++----------------
test/suite-decryption.sh | 4 +-
2 files changed, 243 insertions(+), 165 deletions(-)
