Wireshark-commits: [Wireshark-commits] master-2.2 fef8471: ISAKMP: fix DOI field read size
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 24 Aug 2016 07:41:43 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fef84715505102cc6d1d11504c675cf74c2c2032
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

fef8471 by Mirko Parthey (mirko.parthey@xxxxxx):

    ISAKMP: fix DOI field read size
    
    Read 4 bytes from the packet instead of 1 because that is the
    correct size of the DOI field.
    Reference: RFC 2408
    
    Change-Id: I5745363811bb46af307a925d688ec36cfb29984b
    Reviewed-on: https://code.wireshark.org/review/17271
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 0fcca6f0c8392b16ebfefdc69086d02e1dba2c7e)
    Reviewed-on: https://code.wireshark.org/review/17295
    

Actions performed:

    from  7dc3d01   call_heur_dissector_direct: do not trigger an assert if heuristic dissector rejects packet
    adds  fef8471   ISAKMP: fix DOI field read size


Summary of changes:
 epan/dissectors/packet-isakmp.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)