Wireshark-commits: [Wireshark-commits] master 62eb424: Copy over change from Samba repository:
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 27 Jul 2016 23:23:07 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=62eb424d804942592b8ecf8b9212730e99ce9bae
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

62eb424 by Guy Harris (guy@xxxxxxxxxxxx):

    Copy over change from Samba repository:
    
      commit ed11ce8f12d567a3e0edc1d24aab1784a171ac33
      Author: Douglas Bagnall <douglas.bagnall@xxxxxxxxxxxxxxx>
      Date:   Wed May 4 16:51:37 2016 +1200
    
        Python pidl: avoid segfault with "del obj->attr"
    
        Deleting an attribute in Python (using the "del" statement) is (at
        some stages along a winding path, for C objects) converted into
        setting the attribute to NULL. Not None, actual NULL. The way we
        handled this NULL was to dereference it. This changes the behaviour to
        raising an AttributeError, which is more or less what Python does in
        similar situations with builtin objects.
    
        Signed-off-by: Douglas Bagnall <douglas.bagnall@xxxxxxxxxxxxxxx>
        Reviewed-by: Andrew Bartlett <abartlet@xxxxxxxxx>
    
    Shouldn't affect us, but it makes diffing cleaner.
    
    Change-Id: I8e681dc79c8f4e62b74e2aa5ac2b4924134735c4
    Reviewed-on: https://code.wireshark.org/review/16741
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f0ed91f   Copy over change from Samba repository:
    adds  62eb424   Copy over change from Samba repository:


Summary of changes:
 tools/pidl/lib/Parse/Pidl/Samba4/Python.pm |    8 ++++++++
 1 file changed, 8 insertions(+)