Wireshark-commits: [Wireshark-commits] master f0ed91f: Copy over change from Samba repository:
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 27 Jul 2016 23:21:22 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f0ed91f79dd0e252296cae608673dcf503196d59
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f0ed91f by Guy Harris (guy@xxxxxxxxxxxx):

    Copy over change from Samba repository:
    
      commit f6c79072ca50e05a68b73a80a0ebd635a9bac068
      Author: Andrew Bartlett <abartlet@xxxxxxxxx>
      Date:   Thu Apr 21 21:44:56 2016 +1200
    
        pidl: Correct string handling to use talloc and be in common
    
        The previous string handling assumed the python variables referenced
        by PyString_AS_STRING had infinite life.  When they were re-used
        the C structure started to point at unexpected things.
    
        We now check correctly for Unicode in every case, and we always
        duplicate the string with talloc_strdup()
    
        Signed-off-by: Andrew Bartlett <abartlet@xxxxxxxxx>
        Reviewed-by: Douglas Bagnall <douglas.bagnall@xxxxxxxxxxxxxxx>
    
    Shouldn't affect us, but it makes diffing cleaner.
    
    Change-Id: Ib54b62f5630df46cff6fb0582acd109b263142d2
    Reviewed-on: https://code.wireshark.org/review/16740
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  5623b79   Copy over change from Samba repository:
    adds  f0ed91f   Copy over change from Samba repository:


Summary of changes:
 tools/pidl/lib/Parse/Pidl/Samba4/Python.pm |  103 ++++++++++++++++------------
 1 file changed, 61 insertions(+), 42 deletions(-)