Wireshark-commits: [Wireshark-commits] master 60cdee9: Qt: Handle unhandled filter actions.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 26 Jun 2016 06:11:15 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=60cdee9e307c15928a542adc547f27fd752c4837
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

60cdee9 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Handle unhandled filter actions.
    
    Handle FilterAction::ActionColorize and ::ActionFind. Remove
    ::ActionConversation since it was unused. Assert when we encounter a
    missing FilterAction, similar to what we do in other parts of the code.
    
    Bug: 12363
    Change-Id: I5c1ecd488e5bdb9700a80fc70ec7c047311054b6
    Reviewed-on: https://code.wireshark.org/review/16131
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  291762d   Qt: Try to fix un-maximize behavior on OS X.
    adds  60cdee9   Qt: Handle unhandled filter actions.


Summary of changes:
 ui/qt/filter_action.cpp             |    5 -----
 ui/qt/filter_action.h               |    9 ++++-----
 ui/qt/main_window.cpp               |    8 ++++----
 ui/qt/main_window.h                 |    3 ++-
 ui/qt/main_window_slots.cpp         |   22 ++++++++++++++++------
 ui/qt/protocol_hierarchy_dialog.cpp |    1 +
 ui/qt/search_frame.cpp              |    2 ++
 7 files changed, 29 insertions(+), 21 deletions(-)