Wireshark-commits: [Wireshark-commits] master 291762d: Qt: Try to fix un-maximize behavior on OS X.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 26 Jun 2016 06:10:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=291762d0af8cd49a19c6fc73fce317ee20816a17
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

291762d by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Try to fix un-maximize behavior on OS X.
    
    On OS X, create dialogs with valid parents so that we don't trigger
    QTBUG-46701. Document QDialog's "on top", maximize, and minimize
    behaviors.
    
    Bug: 12544
    Change-Id: I32c0ef01dba3f7132e5fd0cd61f9feb654b92009
    Reviewed-on: https://code.wireshark.org/review/16127
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  974a530   Qt: Conversation and Endpoint dialog performance tweaks.
    adds  291762d   Qt: Try to fix un-maximize behavior on OS X.


Summary of changes:
 ui/qt/geometry_state_dialog.cpp |    7 -------
 ui/qt/geometry_state_dialog.h   |   38 +++++++++++++++++++++++++++++++++++++-
 ui/qt/wireshark_dialog.cpp      |    4 ++--
 ui/qt/wireshark_dialog.h        |    2 +-
 4 files changed, 40 insertions(+), 11 deletions(-)