Wireshark-commits: [Wireshark-commits] master e82d0ae: Qt: Make the syntax line edit less greedy.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 22 Jun 2016 18:02:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e82d0aedec534606b53abf76a4c56781c5c1f83d
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e82d0ae by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Make the syntax line edit less greedy.
    
    In SyntaxLineEdit::event, only grab ShortcutOverride events that have
    Ctrl+Alt modifiers. When the main window display filter edit has focus
    this should let us use text editing shortcuts and most main window
    shorcuts as appropriate. "Most" means everything except for time display
    formats. We might want to use something other than Ctrl+Alt for their
    modifiers.
    
    Bug: 12533
    Ping-Bug: 12270
    Change-Id: I61eb86b80b4237e6907d5e50262b8f5c291b27a7
    Reviewed-on: https://code.wireshark.org/review/16065
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  d46daa1   GTK: Keep display filter applied when switching profiles
    adds  e82d0ae   Qt: Make the syntax line edit less greedy.


Summary of changes:
 ui/qt/syntax_line_edit.cpp |   35 +++++++++++++++++++++++++++--------
 1 file changed, 27 insertions(+), 8 deletions(-)