Wireshark-commits: [Wireshark-commits] master-2.0 2a5c4b6: NSIS: Pass /install to vcredist_xNN.exe.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 22 Jun 2016 12:42:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2a5c4b664ccc08b3157cbe9fdd5f3cc61cea3fa0
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

2a5c4b6 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    NSIS: Pass /install to vcredist_xNN.exe.
    
    Explicitly pass /install to the Visual C++ redistributable installer. A
    few people have reported issues with missing or incorrect redistributable
    files after installing Wireshark but unfortunately haven't provided
    much in the way of further detail. Is it possible that the installer
    sometimes goes into /repair, /layout, or /uninstall modes?
    
    Remove checks for old, unsupported compilers while we're here.
    
    Change-Id: I4e24dbe562c8aeb6ce63ec98ea1601cba5256806
    Reviewed-on: https://code.wireshark.org/review/15120
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
    (cherry picked from commit fc216521850fd5af5bf58ae5e3a90a634d087794)
    Reviewed-on: https://code.wireshark.org/review/16072
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  9458557   Check for negative nanoseconds in io,stat tap.
    adds  2a5c4b6   NSIS: Pass /install to vcredist_xNN.exe.


Summary of changes:
 packaging/nsis/wireshark.nsi |    8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)