Wireshark-commits: [Wireshark-commits] master 1b330db: pcap: Remove the WinPcap version checking fo
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 7 Jun 2016 08:08:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1b330db2e30b202b619c32b0e66665e5fc008917
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1b330db by Yang Luo (hsluoyz@xxxxxxxxx):

    pcap: Remove the WinPcap version checking for the Details dialog
    
    This check only works on the GTK UI's "Details" window. And it
    only can check version numbers. So there's no way for this code to
    be able to differentiate Npcap from WinPcap. And Npcap uses a very
    small version like "0.07", which makes itself not welcomed by this
    checking code.
    
    Change-Id: I861e9decd123e7d30547789c0488043616b17032
    Reviewed-on: https://code.wireshark.org/review/15304
    Reviewed-by: Yang Luo <hsluoyz@xxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  ad0e70f   ERF: Make ERF wiretap forwards compatible.
    adds  1b330db   pcap: Remove the WinPcap version checking for the Details dialog


Summary of changes:
 ui/gtk/capture_if_details_dlg_win32.c |   38 +--------------------------------
 1 file changed, 1 insertion(+), 37 deletions(-)