Wireshark-commits: [Wireshark-commits] master ad0e70f: ERF: Make ERF wiretap forwards compatible.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 7 Jun 2016 03:56:20 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ad0e70f10c1cd18d17874db2264c7e1986b9b9b3
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ad0e70f by Anthony Coddington (anthony.coddington@xxxxxxxxxx):

    ERF: Make ERF wiretap forwards compatible.
    
    Dissector has always been able to cope with unknown record types so pass them
    through (and call the data dissector from the ERF dissector in this case).
    Previously was stopping processing on the first unrecognized record which is
    very unhelpful for otherwise valid files that have new types mixed in.
    
    Remove ERF type check altogether from open heuristic as ERF type could be past
    48 in future and with more extension headers bit any byte value could be valid.
    Also allow setting ERF_RECORDS_TO_CHECK to 0 to force skipping the heuristic.
    
    Change-Id: I8331eef30ba2e949564f418b3100bd73b8f58116
    Reviewed-on: https://code.wireshark.org/review/15361
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  0ec5a27   Qt: RTP audio stream fixups.
    adds  ad0e70f   ERF: Make ERF wiretap forwards compatible.


Summary of changes:
 epan/dissectors/packet-erf.c |    1 +
 wiretap/erf.c                |   14 ++++++--------
 wiretap/erf.h                |    3 ---
 3 files changed, 7 insertions(+), 11 deletions(-)