Wireshark-commits: [Wireshark-commits] master-1.12 fb9dcfa: UMTS_FP: fix handling reserved C/T valu
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 5 Jun 2016 04:11:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fb9dcfa8e5df3ea3207335491b86be8cbb21eeaf
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

fb9dcfa by Evan Huus (eapache@xxxxxxxxx):

    UMTS_FP: fix handling reserved C/T value
    
    The spec puts the reserved value at 0xf but our internal table has 'unknown' at
    0; since all the other values seem to be offset-by-one, just take the modulus
    0xf to avoid running off the end of the table.
    
    # Conflicts:
    #	epan/dissectors/packet-umts_fp.c
    
    Bug: 12191
    Change-Id: I83c8fb66797bbdee52a2246fb1eea6e37cbc7eb0
    Reviewed-on: https://code.wireshark.org/review/15722
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 7d7190695ce2ff269fdffb04e87139995cde21f4)
    Reviewed-on: https://code.wireshark.org/review/15726
    

Actions performed:

    from  1202a40   CSN1: fix dissection of variable bitmaps
    adds  fb9dcfa   UMTS_FP: fix handling reserved C/T value


Summary of changes:
 epan/dissectors/packet-umts_fp.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)