Wireshark-commits: [Wireshark-commits] master-2.0 ff27d85: UMTS_FP: fix handling reserved C/T value
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 5 Jun 2016 04:11:14 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ff27d85e3ec903d647847f8aeef3476fe8b27e91
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

ff27d85 by Evan Huus (eapache@xxxxxxxxx):

    UMTS_FP: fix handling reserved C/T value
    
    The spec puts the reserved value at 0xf but our internal table has 'unknown' at
    0; since all the other values seem to be offset-by-one, just take the modulus
    0xf to avoid running off the end of the table.
    
    Bug: 12191
    Change-Id: I83c8fb66797bbdee52a2246fb1eea6e37cbc7eb0
    Reviewed-on: https://code.wireshark.org/review/15722
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    (cherry picked from commit 7d7190695ce2ff269fdffb04e87139995cde21f4)
    Reviewed-on: https://code.wireshark.org/review/15725
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  bfb1d6d   Qt ui code: fix qreal type problems on ARM platform
    adds  ff27d85   UMTS_FP: fix handling reserved C/T value


Summary of changes:
 epan/dissectors/packet-umts_fp.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)