Wireshark-commits: [Wireshark-commits] master 7f2de76: Qt: Monitor mode fixups.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 31 May 2016 19:28:06 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7f2de76c634ff01b3bfa24ca04549c62078ae3d4
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7f2de76 by Gerald Combs (gerald@xxxxxxxx):

    Qt: Monitor mode fixups.
    
    When we update the monitor mode setting for an interface, update its
    link type list.
    
    Start filling in interface columns from a common function instead of
    multiple places.
    
    Rename some member function names to match
    https://www.wireshark.org/docs/wsdg_html_chunked/ChUIQt.html#_coding_practices_and_naming_conventions
    
    Bug: 11364
    Change-Id: I26ac7e9719863169b62069e49ebf17ed97fbe516
    Reviewed-on: https://code.wireshark.org/review/15583
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  f61cdc3   RTPS: Updated name of CRC field
    adds  7f2de76   Qt: Monitor mode fixups.


Summary of changes:
 ui/qt/capture_interfaces_dialog.cpp |  237 ++++++++++++++++++++++++-----------
 ui/qt/capture_interfaces_dialog.h   |   16 +--
 ui/qt/capture_interfaces_dialog.ui  |    2 +-
 ui/qt/main_window_slots.cpp         |    2 +-
 4 files changed, 171 insertions(+), 86 deletions(-)