Wireshark-commits: [Wireshark-commits] master-2.0 a9b2605: qt: fix crash when saving RTP audio
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 31 May 2016 18:16:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a9b26052366af7c0b230799ea868112351c57e2d
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

a9b2605 by Dario Lombardo (lomato@xxxxxxxxx):

    qt: fix crash when saving RTP audio
    
    The UI crashes when saving a RTP due to a division by zero.
    To reproduce: open a RTP capture file, Telephony->RTP->RTP Streams,
    then choose a stream, ANALYZE, SAVE, AUDIO, choose a path.
    
    Bug: 12211
    Change-Id: I51d61eb6797fc82c1b03254abaec839d3a1e281d
    Reviewed-on: https://code.wireshark.org/review/15621
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 057d8a80f0a3d91c1346ff77e079539cad7887d6)
    Reviewed-on: https://code.wireshark.org/review/15650
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  895b293   Qt: Fix compilation for Qt 4.
    adds  a9b2605   qt: fix crash when saving RTP audio


Summary of changes:
 ui/qt/rtp_analysis_dialog.cpp |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)